Pouzor
ab36ba6f81
Add a Proxmox VE importer that reads the /api2/json REST API with a read-only
API token and drops hosts (proxmox), VMs (vm) and LXC containers (lxc) onto the
canvas as typed nodes with run state and hardware specs (vCPU/RAM/disk).
- Backend: proxmox_service (httpx) + proxmox routes (test-connection, import,
import-pending, config). Two-tier dedupe — merge onto an existing scanned node
by IP, else synthetic pve-{host}-{vmid} identity. Update-in-place, never
deletes. Host->guest rendered as a 'virtual' edge via the pending-link flow.
- Security: token is env-only (PROXMOX_TOKEN_*), never written to disk by the
app, never returned by any endpoint; errors are credential-sanitized.
- Auto-sync: optional scheduled re-import into pending (APScheduler job).
- PendingDevice.properties carries specs through approve (+ migration).
- Frontend: ProxmoxImportModal, sidebar entry, pending inventory source filter,
Settings auto-sync section, proxmoxApi client.
- Docs: docs/proxmox-import.md, README + FEATURES sections, .env.example keys.
- Tests: backend service/router/scheduler, frontend modal/client/pending.
ha-relevant: maybe
124 lines
4.8 KiB
Python
124 lines
4.8 KiB
Python
"""Unit tests for the Proxmox VE import service (parsing, props, sanitizer)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import httpx
|
|
import pytest
|
|
|
|
from app.services import proxmox_service as svc
|
|
|
|
|
|
def test_gb_conversion() -> None:
|
|
assert svc._gb(1024 ** 3) == 1.0
|
|
assert svc._gb(2 * 1024 ** 3) == 2.0
|
|
assert svc._gb(0) is None
|
|
assert svc._gb(None) is None
|
|
assert svc._gb("nope") is None
|
|
|
|
|
|
def test_extract_qemu_ip_skips_loopback() -> None:
|
|
payload = {
|
|
"result": [
|
|
{"name": "lo", "ip-addresses": [{"ip-address-type": "ipv4", "ip-address": "127.0.0.1"}]},
|
|
{"name": "eth0", "ip-addresses": [{"ip-address-type": "ipv4", "ip-address": "192.168.1.20"}]},
|
|
]
|
|
}
|
|
assert svc._extract_qemu_ip(payload) == "192.168.1.20"
|
|
assert svc._extract_qemu_ip(None) is None
|
|
assert svc._extract_qemu_ip({"result": []}) is None
|
|
|
|
|
|
def test_extract_lxc_ip_parses_net0_static() -> None:
|
|
cfg = {"net0": "name=eth0,bridge=vmbr0,ip=192.168.1.30/24,gw=192.168.1.1"}
|
|
assert svc._extract_lxc_ip(cfg) == "192.168.1.30"
|
|
# DHCP → no static IP
|
|
assert svc._extract_lxc_ip({"net0": "name=eth0,bridge=vmbr0,ip=dhcp"}) is None
|
|
assert svc._extract_lxc_ip(None) is None
|
|
|
|
|
|
def test_host_and_guest_node_mapping() -> None:
|
|
host = svc._host_node({"node": "pve1", "status": "online", "maxcpu": 8, "maxmem": 16 * 1024 ** 3, "maxdisk": 500 * 1024 ** 3})
|
|
assert host["type"] == "proxmox"
|
|
assert host["ieee_address"] == "pve-node-pve1"
|
|
assert host["cpu_count"] == 8
|
|
assert host["ram_gb"] == 16.0
|
|
assert host["status"] == "online"
|
|
assert host["parent_ieee"] is None
|
|
|
|
vm = svc._guest_node({"vmid": 101, "name": "web", "status": "running", "maxcpu": 2, "maxmem": 2 * 1024 ** 3, "maxdisk": 32 * 1024 ** 3}, "pve1", "qemu", "10.0.0.5")
|
|
assert vm["type"] == "vm"
|
|
assert vm["ieee_address"] == "pve-pve1-101"
|
|
assert vm["ip"] == "10.0.0.5"
|
|
assert vm["status"] == "online"
|
|
assert vm["parent_ieee"] == "pve-node-pve1"
|
|
|
|
ct = svc._guest_node({"vmid": 200, "name": "db", "status": "stopped"}, "pve1", "lxc", None)
|
|
assert ct["type"] == "lxc"
|
|
assert ct["status"] == "offline"
|
|
|
|
|
|
def test_build_properties_includes_specs() -> None:
|
|
node = {"vmid": 101, "model": "QEMU", "cpu_count": 4, "ram_gb": 8.0, "disk_gb": 40.0}
|
|
props = svc.build_proxmox_properties(node)
|
|
keys = {p["key"] for p in props}
|
|
assert {"VMID", "CPU Cores", "RAM", "Disk", "Source"} <= keys
|
|
assert all(p["visible"] is False for p in props)
|
|
|
|
|
|
def test_parse_inventory_builds_host_guest_edges() -> None:
|
|
hosts = [{"node": "pve1", "status": "online", "maxcpu": 4}]
|
|
guests = {"pve1": [svc._guest_node({"vmid": 101, "name": "web", "status": "running"}, "pve1", "qemu", None)]}
|
|
nodes, edges = svc._parse_inventory(hosts, guests)
|
|
assert len(nodes) == 2
|
|
assert edges == [{"source": "pve-node-pve1", "target": "pve-pve1-101"}]
|
|
|
|
|
|
def test_sanitize_error_hides_credentials() -> None:
|
|
exc = httpx.HTTPStatusError(
|
|
"boom", request=httpx.Request("GET", "https://h/api2/json"),
|
|
response=httpx.Response(401),
|
|
)
|
|
msg = svc._sanitize_proxmox_error(exc)
|
|
assert "token" not in msg.lower() or "check the api token" in msg.lower()
|
|
assert "Authentication failed" in msg
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_fetch_inventory_happy_path() -> None:
|
|
async def fake_get_json(client, path: str):
|
|
if path == "/nodes":
|
|
return [{"node": "pve1", "status": "online", "maxcpu": 8, "maxmem": 16 * 1024 ** 3}]
|
|
if path == "/nodes/pve1/qemu":
|
|
return [{"vmid": 101, "name": "web", "status": "running", "maxmem": 2 * 1024 ** 3}]
|
|
if path == "/nodes/pve1/lxc":
|
|
return [{"vmid": 200, "name": "db", "status": "stopped"}]
|
|
if path.endswith("/agent/network-get-interfaces"):
|
|
return {"result": [{"name": "eth0", "ip-addresses": [{"ip-address-type": "ipv4", "ip-address": "10.0.0.5"}]}]}
|
|
if path.endswith("/config"):
|
|
return {"net0": "name=eth0,ip=10.0.0.6/24"}
|
|
return None
|
|
|
|
with patch.object(svc, "_get_json", new=AsyncMock(side_effect=fake_get_json)):
|
|
nodes, edges = await svc.fetch_proxmox_inventory("h", 8006, "u@pam!t", "sec")
|
|
|
|
by_type = {n["type"] for n in nodes}
|
|
assert by_type == {"proxmox", "vm", "lxc"}
|
|
vm = next(n for n in nodes if n["type"] == "vm")
|
|
assert vm["ip"] == "10.0.0.5"
|
|
ct = next(n for n in nodes if n["type"] == "lxc")
|
|
assert ct["ip"] == "10.0.0.6"
|
|
assert len(edges) == 2
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_test_connection_returns_message() -> None:
|
|
async def fake_get_json(client, path: str):
|
|
return {"version": "8.2.2"}
|
|
|
|
with patch.object(svc, "_get_json", new=AsyncMock(side_effect=fake_get_json)):
|
|
ok, msg = await svc.test_proxmox_connection("h", 8006, "u@pam!t", "sec")
|
|
assert ok is True
|
|
assert "8.2.2" in msg
|