Pouzor
20e1820a4e
Three follow-ups to PR #158 review: 1. Promote collapsed to NodeData.collapsed The flag was previously stashed inside NodeData.custom_colors, which is a colors/style object — semantically wrong. Move it to a first-class boolean on NodeData. Persistence keeps the existing API shape: serialize writes it into the custom_colors blob (alongside width/height/z_order, matching how groupRect already stashes layout metadata), and deserialize hoists it back. Legacy saves from the original PR shape load correctly. 2. Re-route cross-zone edges to the collapsed ancestor Previously any edge touching a hidden node was dropped, so a Zigbee coordinator outside a collapsed mesh lost all visible links to it. rewireEdgesForCollapse now walks each endpoint up the parentId chain to its nearest visible ancestor, surfaces a single stub edge on the collapsed zone, de-dupes parallel rewires (a 20-device mesh becomes one stub, not twenty), and drops edges that would self-loop on a zone or reference an orphan. 3. Revert package-lock.json churn The 63-line diff from the original PR was npm-version drift (libc arrays stripped from optional deps), unrelated to the feature. Tests: - canvasStore.collapse: updated to assert on data.collapsed. - collapseFilter: 8 cases for visibility + 7 for edge rewire, covering cross-boundary, nested collapse, sibling self-loop, mesh dedup, and orphan endpoints. - canvasSerializer.collapse: round-trip + legacy-shape compat.
33 lines
957 B
TypeScript
33 lines
957 B
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import type { NodeData } from '@/types'
|
|
|
|
/**
|
|
* Type-level assertions for the collapse feature. Behavioral coverage lives
|
|
* in:
|
|
* - src/stores/__tests__/canvasStore.collapse.test.ts (store action)
|
|
* - src/utils/__tests__/collapseFilter.test.ts (BFS + edge rewire)
|
|
* - src/utils/__tests__/canvasSerializer.collapse.test.ts (round-trip)
|
|
*/
|
|
describe('NodeData.collapsed', () => {
|
|
it('accepts a boolean collapsed flag as a first-class field', () => {
|
|
const nodeData: NodeData = {
|
|
label: 'Test Zone',
|
|
type: 'groupRect',
|
|
status: 'online',
|
|
services: [],
|
|
collapsed: true,
|
|
}
|
|
expect(nodeData.collapsed).toBe(true)
|
|
})
|
|
|
|
it('treats a missing flag as expanded', () => {
|
|
const nodeData: NodeData = {
|
|
label: 'Test Zone',
|
|
type: 'groupRect',
|
|
status: 'online',
|
|
services: [],
|
|
}
|
|
expect(nodeData.collapsed).toBeUndefined()
|
|
})
|
|
})
|