url/homelable
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: removed setState within an effect, responsibility moved to parent key

Browse Source
This commit is contained in:
findthelorax
2026-04-20 00:13:07 -04:00
parent 9dddd00858
commit f6de7d1770
3 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/components/modals/__tests__/NodeModal.test.tsx
+3 -3
View File
@@ -134,12 +134,12 @@ describe('NodeModal', () => {
const onClose = vi.fn()
const onSubmit = vi.fn()
const { rerender } = render(<NodeModal open onClose={onClose} onSubmit={onSubmit} />)
const { rerender } = render(<NodeModal key="open-1" open onClose={onClose} onSubmit={onSubmit} />)
fireEvent.change(screen.getByPlaceholderText('My Server'), { target: { value: 'Temp Node' } })
fireEvent.change(screen.getByPlaceholderText('server.lan'), { target: { value: 'temp.local' } })
rerender(<NodeModal open={false} onClose={onClose} onSubmit={onSubmit} />)
rerender(<NodeModal open onClose={onClose} onSubmit={onSubmit} />)
rerender(<NodeModal key="closed" open={false} onClose={onClose} onSubmit={onSubmit} />)
rerender(<NodeModal key="open-2" open onClose={onClose} onSubmit={onSubmit} />)
expect((screen.getByPlaceholderText('My Server') as HTMLInputElement).value).toBe('')
expect((screen.getByPlaceholderText('server.lan') as HTMLInputElement).value).toBe('')