From e9152df17a833a92bc9817b0f175c2a5a759fae7 Mon Sep 17 00:00:00 2001
From: Pouzor <remy.jardinet@gmail.com>
Date: Tue, 31 Mar 2026 00:01:31 +0200
Subject: [PATCH] fix: remove stale reschedule call from scan config after
 settings endpoint split

---
 backend/app/api/routes/scan.py |  2 --
 backend/tests/test_scan.py     | 20 --------------------
 2 files changed, 22 deletions(-)

diff --git a/backend/app/api/routes/scan.py b/backend/app/api/routes/scan.py
index ea19242..7d9a535 100644
--- a/backend/app/api/routes/scan.py
+++ b/backend/app/api/routes/scan.py
@@ -8,7 +8,6 @@ from sqlalchemy.ext.asyncio import AsyncSession
 
 from app.api.deps import get_current_user
 from app.core.config import settings
-from app.core.scheduler import reschedule_status_checks
 from app.db.database import AsyncSessionLocal, get_db
 from app.db.models import Node, PendingDevice, ScanRun
 from app.schemas.nodes import NodeCreate
@@ -111,7 +110,6 @@ async def update_scan_config(payload: ScanConfig, _: str = Depends(get_current_u
     try:
         settings.scanner_ranges = payload.ranges
         settings.save_overrides()
-        reschedule_status_checks(payload.interval_seconds)
         return payload
     except Exception as exc:
         raise HTTPException(status_code=500, detail=str(exc)) from exc
diff --git a/backend/tests/test_scan.py b/backend/tests/test_scan.py
index c34b44d..c03b8b4 100644
--- a/backend/tests/test_scan.py
+++ b/backend/tests/test_scan.py
@@ -156,26 +156,6 @@ async def test_ignore_device(client: AsyncClient, headers, pending_device):
     assert hidden_res.json() == []
 
 
-# --- Scan config ---
-
-@pytest.mark.asyncio
-async def test_update_scan_config_reschedules_interval(client: AsyncClient, headers):
-    """Saving a new interval must reschedule the running APScheduler job immediately."""
-    with (
-        patch("app.api.routes.scan.settings") as mock_settings,
-        patch("app.api.routes.scan.reschedule_status_checks") as mock_reschedule,
-    ):
-        mock_settings.scanner_ranges = []
-        mock_settings.save_overrides = lambda: None
-        res = await client.post(
-            "/api/v1/scan/config",
-            json={"ranges": ["192.168.1.0/24"], "interval_seconds": 30},
-            headers=headers,
-        )
-    assert res.status_code == 200
-    mock_reschedule.assert_called_once_with(30)
-
-
 # --- Scan runs ---
 
 @pytest.mark.asyncio