From b17299f53115654f52c15dd2fe0e997c4019454f Mon Sep 17 00:00:00 2001 From: Pouzor Date: Sat, 9 May 2026 23:53:33 +0200 Subject: [PATCH] fix(pending): drop dangling onNodeApproved call + add keydown deps Single approve was calling a removed prop ref (caught by review). Keydown effect now has explicit deps so it doesn't re-bind every render. --- frontend/src/components/modals/PendingDevicesModal.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/src/components/modals/PendingDevicesModal.tsx b/frontend/src/components/modals/PendingDevicesModal.tsx index 8f03be6..c9fa61f 100644 --- a/frontend/src/components/modals/PendingDevicesModal.tsx +++ b/frontend/src/components/modals/PendingDevicesModal.tsx @@ -258,7 +258,6 @@ export function PendingDevicesModal({ open, onClose, highlightId, initialStatus toast.success(`Approved ${nodeData.label}${extra}`) setDevices((prev) => prev.filter((d) => d.id !== device.id)) setSelected(null) - onNodeApproved(nodeId) } catch { toast.error('Failed to approve device') } @@ -352,7 +351,8 @@ export function PendingDevicesModal({ open, onClose, highlightId, initialStatus } window.addEventListener('keydown', handler) return () => window.removeEventListener('keydown', handler) - }) + // eslint-disable-next-line react-hooks/exhaustive-deps + }, [open, selectMode, selectedIds, filtered]) return ( <>