fix: all lint errors, test + lint pre-commit passing

Frontend: - Split nodeTypes/edgeTypes into separate .ts files (react-refresh) - Remove setState-in-effect in NodeModal (key prop reset) - Fix handleSave accessed before declaration (useRef pattern) - Exclude src/components/ui/** from eslint (shadcn generated) - Use defineConfig from vitest/config for test type support Backend: - ruff --fix: sort imports, datetime.UTC alias - Raise line-length to 120, ignore E501 in tests - Break long update_node/update_edge signatures - pyproject.toml: per-file-ignores for tests
2026-03-06 23:58:10 +01:00
parent 150302c3f7
commit 44a448e26d
30 changed files with 1731 additions and 63 deletions
@@ -0,0 +1,39 @@
+import pytest
+from httpx import ASGITransport, AsyncClient
+from sqlalchemy.ext.asyncio import AsyncSession, async_sessionmaker, create_async_engine
+
+from app.db.database import Base, get_db
+from app.main import app
+
+TEST_DB_URL = "sqlite+aiosqlite:///:memory:"
+
+
+@pytest.fixture
+async def db_session():
+    engine = create_async_engine(TEST_DB_URL)
+    async with engine.begin() as conn:
+        await conn.run_sync(Base.metadata.create_all)
+    session_factory = async_sessionmaker(engine, class_=AsyncSession, expire_on_commit=False)
+    async with session_factory() as session:
+        yield session
+    async with engine.begin() as conn:
+        await conn.run_sync(Base.metadata.drop_all)
+    await engine.dispose()
+
+
+@pytest.fixture
+async def client(db_session: AsyncSession):
+    app.dependency_overrides[get_db] = lambda: db_session
+    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as c:
+        yield c
+    app.dependency_overrides.clear()
+
+
+@pytest.fixture
+def auth_headers(client):
+    """Returns a coroutine that logs in and returns auth headers."""
+    async def _get():
+        res = await client.post("/api/v1/auth/login", json={"username": "admin", "password": "admin"})
+        token = res.json()["access_token"]
+        return {"Authorization": f"Bearer {token}"}
+    return _get
@@ -0,0 +1,39 @@
+from unittest.mock import patch
+
+import pytest
+from httpx import AsyncClient
+
+
+@pytest.fixture
+def mock_credentials():
+    with patch("app.api.routes.auth._load_credentials", return_value=("admin", "$2b$12$o/LWyvmBc978CNpSsHxcveXN0WqjAGW/gBR0.U.HURWbaYD3GCDqS")):
+        yield
+
+
+async def test_login_success(client: AsyncClient, mock_credentials):
+    res = await client.post("/api/v1/auth/login", json={"username": "admin", "password": "admin"})
+    assert res.status_code == 200
+    data = res.json()
+    assert "access_token" in data
+    assert data["token_type"] == "bearer"
+
+
+async def test_login_wrong_password(client: AsyncClient, mock_credentials):
+    res = await client.post("/api/v1/auth/login", json={"username": "admin", "password": "wrong"})
+    assert res.status_code == 401
+
+
+async def test_login_wrong_username(client: AsyncClient, mock_credentials):
+    res = await client.post("/api/v1/auth/login", json={"username": "notadmin", "password": "admin"})
+    assert res.status_code == 401
+
+
+async def test_protected_route_requires_auth(client: AsyncClient):
+    res = await client.get("/api/v1/nodes/")
+    assert res.status_code == 403
+
+
+async def test_health_is_public(client: AsyncClient):
+    res = await client.get("/api/v1/health")
+    assert res.status_code == 200
+    assert res.json() == {"status": "ok"}
@@ -0,0 +1,54 @@
+from unittest.mock import patch
+
+import pytest
+from httpx import AsyncClient
+
+TOKEN_HASH = "$2b$12$o/LWyvmBc978CNpSsHxcveXN0WqjAGW/gBR0.U.HURWbaYD3GCDqS"
+
+
+@pytest.fixture
+async def headers(client: AsyncClient):
+    with patch("app.api.routes.auth._load_credentials", return_value=("admin", TOKEN_HASH)):
+        res = await client.post("/api/v1/auth/login", json={"username": "admin", "password": "admin"})
+    token = res.json()["access_token"]
+    return {"Authorization": f"Bearer {token}"}
+
+
+@pytest.fixture
+async def two_nodes(client: AsyncClient, headers: dict):
+    n1 = (await client.post("/api/v1/nodes/", json={"type": "router", "label": "R1", "status": "online"}, headers=headers)).json()
+    n2 = (await client.post("/api/v1/nodes/", json={"type": "switch", "label": "SW1", "status": "online"}, headers=headers)).json()
+    return n1["id"], n2["id"]
+
+
+async def test_create_edge(client: AsyncClient, headers: dict, two_nodes):
+    src, tgt = two_nodes
+    res = await client.post("/api/v1/edges/", json={"source": src, "target": tgt, "type": "ethernet"}, headers=headers)
+    assert res.status_code == 201
+    data = res.json()
+    assert data["source"] == src
+    assert data["target"] == tgt
+    assert data["type"] == "ethernet"
+
+
+async def test_create_vlan_edge(client: AsyncClient, headers: dict, two_nodes):
+    src, tgt = two_nodes
+    res = await client.post("/api/v1/edges/", json={"source": src, "target": tgt, "type": "vlan", "vlan_id": 20, "label": "VLAN 20"}, headers=headers)
+    assert res.status_code == 201
+    assert res.json()["vlan_id"] == 20
+
+
+async def test_list_edges(client: AsyncClient, headers: dict, two_nodes):
+    src, tgt = two_nodes
+    await client.post("/api/v1/edges/", json={"source": src, "target": tgt, "type": "ethernet"}, headers=headers)
+    res = await client.get("/api/v1/edges/", headers=headers)
+    assert res.status_code == 200
+    assert len(res.json()) == 1
+
+
+async def test_delete_edge(client: AsyncClient, headers: dict, two_nodes):
+    src, tgt = two_nodes
+    edge_id = (await client.post("/api/v1/edges/", json={"source": src, "target": tgt, "type": "wifi"}, headers=headers)).json()["id"]
+    res = await client.delete(f"/api/v1/edges/{edge_id}", headers=headers)
+    assert res.status_code == 204
+    assert len((await client.get("/api/v1/edges/", headers=headers)).json()) == 0
@@ -0,0 +1,67 @@
+from unittest.mock import patch
+
+import pytest
+from httpx import AsyncClient
+
+TOKEN_HASH = "$2b$12$o/LWyvmBc978CNpSsHxcveXN0WqjAGW/gBR0.U.HURWbaYD3GCDqS"
+
+
+@pytest.fixture
+async def headers(client: AsyncClient):
+    with patch("app.api.routes.auth._load_credentials", return_value=("admin", TOKEN_HASH)):
+        res = await client.post("/api/v1/auth/login", json={"username": "admin", "password": "admin"})
+    token = res.json()["access_token"]
+    return {"Authorization": f"Bearer {token}"}
+
+
+async def test_list_nodes_empty(client: AsyncClient, headers: dict):
+    res = await client.get("/api/v1/nodes/", headers=headers)
+    assert res.status_code == 200
+    assert res.json() == []
+
+
+async def test_create_node(client: AsyncClient, headers: dict):
+    payload = {"type": "server", "label": "My Server", "ip": "192.168.1.10", "status": "unknown"}
+    res = await client.post("/api/v1/nodes/", json=payload, headers=headers)
+    assert res.status_code == 201
+    data = res.json()
+    assert data["label"] == "My Server"
+    assert data["ip"] == "192.168.1.10"
+    assert "id" in data
+
+
+async def test_get_node(client: AsyncClient, headers: dict):
+    create = await client.post("/api/v1/nodes/", json={"type": "router", "label": "Router", "status": "online"}, headers=headers)
+    node_id = create.json()["id"]
+    res = await client.get(f"/api/v1/nodes/{node_id}", headers=headers)
+    assert res.status_code == 200
+    assert res.json()["id"] == node_id
+
+
+async def test_get_node_not_found(client: AsyncClient, headers: dict):
+    res = await client.get("/api/v1/nodes/nonexistent-id", headers=headers)
+    assert res.status_code == 404
+
+
+async def test_update_node(client: AsyncClient, headers: dict):
+    create = await client.post("/api/v1/nodes/", json={"type": "server", "label": "Old", "status": "unknown"}, headers=headers)
+    node_id = create.json()["id"]
+    res = await client.patch(f"/api/v1/nodes/{node_id}", json={"label": "New", "ip": "10.0.0.1"}, headers=headers)
+    assert res.status_code == 200
+    assert res.json()["label"] == "New"
+    assert res.json()["ip"] == "10.0.0.1"
+
+
+async def test_delete_node(client: AsyncClient, headers: dict):
+    create = await client.post("/api/v1/nodes/", json={"type": "switch", "label": "Switch", "status": "unknown"}, headers=headers)
+    node_id = create.json()["id"]
+    res = await client.delete(f"/api/v1/nodes/{node_id}", headers=headers)
+    assert res.status_code == 204
+    assert (await client.get(f"/api/v1/nodes/{node_id}", headers=headers)).status_code == 404
+
+
+async def test_list_nodes_returns_all(client: AsyncClient, headers: dict):
+    for i in range(3):
+        await client.post("/api/v1/nodes/", json={"type": "generic", "label": f"Node {i}", "status": "unknown"}, headers=headers)
+    res = await client.get("/api/v1/nodes/", headers=headers)
+    assert len(res.json()) == 3