From 3cd2674f68e2015f9b4168841c796a9fcbf32ed6 Mon Sep 17 00:00:00 2001 From: JustVugg Date: Sun, 19 Jul 2026 12:29:33 +0200 Subject: [PATCH] =?UTF-8?q?release:=20fix=20the=20Windows=20job=20shell=20?= =?UTF-8?q?=E2=80=94=20'msys2=20{0}',=20not=20'msys2'=20(+=20inherit=20PAT?= =?UTF-8?q?H=20for=207z)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GitHub Actions shells are format strings; the bare 'msys2' string made the v1.0.0 tag build fail before its first step ('Invalid shell option'). Same invocation ci.yml already uses. path-type: inherit so the Package step can reach the runner's 7z.exe. Co-Authored-By: Claude Fable 5 --- .github/workflows/release.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 245d24f..e471fb9 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -24,7 +24,9 @@ jobs: name: windows-x86_64 ext: ".exe" make_args: "" - shell: msys2 + # GitHub shells are format strings: 'msys2 {0}', never bare 'msys2' + # (the v1.0.0 tag build failed on exactly this). Same as ci.yml. + shell: "msys2 {0}" runs-on: ${{ matrix.os }} defaults: run: @@ -32,11 +34,14 @@ jobs: steps: - uses: actions/checkout@v4 - - if: matrix.shell == 'msys2' + - if: matrix.os == 'windows-latest' uses: msys2/setup-msys2@v2 with: msystem: UCRT64 update: false + # inherit: the Package step calls the runner's 7z.exe, which lives on + # the Windows PATH; the default minimal path would not see it. + path-type: inherit install: >- make mingw-w64-ucrt-x86_64-gcc