From 2d798e29831c2f640e3f40e8f574af7e18632a1d Mon Sep 17 00:00:00 2001
From: Tola Leng <tolaleng.oss@gmail.com>
Date: Thu, 5 Jun 2025 20:59:46 +0800
Subject: [PATCH] Fix: Test Email dialog and remove Test Connection button

---
 .../settings/general/GeneralSettingsPanel.tsx     | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/application/src/components/settings/general/GeneralSettingsPanel.tsx b/application/src/components/settings/general/GeneralSettingsPanel.tsx
index b43cf48..b990634 100644
--- a/application/src/components/settings/general/GeneralSettingsPanel.tsx
+++ b/application/src/components/settings/general/GeneralSettingsPanel.tsx
@@ -29,8 +29,6 @@ const GeneralSettingsPanel: React.FC<GeneralSettingsPanelProps> = () => {
     error,
     updateSettings,
     isUpdating,
-    testEmailConnection,
-    isTestingConnection
   } = useSystemSettings();
 
   const form = useForm<GeneralSettings>({
@@ -99,15 +97,6 @@ const GeneralSettingsPanel: React.FC<GeneralSettingsPanelProps> = () => {
     }
   };
 
-  const handleTestConnection = async () => {
-    try {
-      const smtpConfig = form.getValues('smtp');
-      await testEmailConnection(smtpConfig);
-    } catch (error) {
-      console.error("Error testing connection:", error);
-    }
-  };
-
   const handleEditClick = () => {
     console.log('Edit button clicked, setting isEditing to true');
     setIsEditing(true);
@@ -205,13 +194,10 @@ const GeneralSettingsPanel: React.FC<GeneralSettingsPanelProps> = () => {
                     form={form} 
                     isEditing={isEditing} 
                     settings={settings}
-                    handleTestConnection={handleTestConnection}
-                    isTestingConnection={isTestingConnection}
                   />
                 </TabsContent>
               </Tabs>
               
-              {/* Save and Cancel buttons - only show when editing */}
               {isEditing && (
                 <div className="flex justify-between mt-6">
                   <Button type="button" variant="outline" onClick={handleCancelClick} disabled={isUpdating}>
@@ -226,7 +212,6 @@ const GeneralSettingsPanel: React.FC<GeneralSettingsPanelProps> = () => {
           </Form>
         </CardContent>
         
-        {/* Edit button - only show when not editing and outside the form */}
         {!isEditing && (
           <CardFooter>
             <Button type="button" onClick={handleEditClick}>