fix(windows): resolve control flow and path quoting in scheduler task execution
This commit is contained in:
@@ -18,7 +18,10 @@ class TestSchedulerWindows(unittest.TestCase):
|
||||
stderr = ""
|
||||
return Proc()
|
||||
|
||||
with mock.patch("subprocess.run", side_effect=fake_run):
|
||||
mock_open = mock.mock_open()
|
||||
with mock.patch("subprocess.run", side_effect=fake_run), \
|
||||
mock.patch("os.makedirs") as mock_makedirs, \
|
||||
mock.patch("builtins.open", mock_open):
|
||||
ok, msg = schedule("/p/my project", backend="mock", hour=3, minute=17)
|
||||
self.assertTrue(ok)
|
||||
self.assertIn("via Windows Task Scheduler", msg)
|
||||
@@ -30,13 +33,21 @@ class TestSchedulerWindows(unittest.TestCase):
|
||||
self.assertTrue(cmd[3].startswith("SkillOpt-Sleep-"))
|
||||
self.assertIn("my_project", cmd[3])
|
||||
self.assertEqual(cmd[4], "/tr")
|
||||
self.assertIn("cmd.exe", cmd[5])
|
||||
self.assertIn("run.cmd", cmd[5])
|
||||
self.assertEqual(cmd[6], "/sc")
|
||||
self.assertEqual(cmd[7], "daily")
|
||||
self.assertEqual(cmd[8], "/st")
|
||||
self.assertEqual(cmd[9], "03:17")
|
||||
self.assertEqual(cmd[10], "/f")
|
||||
|
||||
mock_makedirs.assert_called_once()
|
||||
mock_open.assert_called_once()
|
||||
# Verify the content written to the helper script
|
||||
handle = mock_open()
|
||||
written = "".join(call[0][0] for call in handle.write.call_args_list)
|
||||
self.assertIn("@echo off", written)
|
||||
self.assertIn("run --project", written)
|
||||
|
||||
@mock.patch("sys.platform", "win32")
|
||||
@mock.patch("shutil.which", return_value="C:\\Windows\\System32\\schtasks.exe")
|
||||
def test_unschedule_windows(self, mock_which):
|
||||
@@ -51,7 +62,9 @@ class TestSchedulerWindows(unittest.TestCase):
|
||||
stderr = ""
|
||||
return Proc()
|
||||
|
||||
with mock.patch("subprocess.run", side_effect=fake_run):
|
||||
with mock.patch("subprocess.run", side_effect=fake_run), \
|
||||
mock.patch("os.path.exists", return_value=True), \
|
||||
mock.patch("os.remove") as mock_remove:
|
||||
ok, msg = unschedule("/p/my project")
|
||||
self.assertTrue(ok)
|
||||
self.assertEqual(len(calls), 1)
|
||||
@@ -61,3 +74,4 @@ class TestSchedulerWindows(unittest.TestCase):
|
||||
self.assertEqual(cmd[2], "/tn")
|
||||
self.assertTrue(cmd[3].startswith("SkillOpt-Sleep-"))
|
||||
self.assertEqual(cmd[4], "/f")
|
||||
mock_remove.assert_called_once()
|
||||
|
||||
Reference in New Issue
Block a user